[MPlayer-dev-eng] [PATCH] bigendian fix for hwac3

[Ulion]

2007/9/13, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Sep 13, 2007 at 01:22:46PM +0200, Reimar Döffinger wrote:
> > On Thu, Sep 13, 2007 at 01:14:40PM +0200, Reimar Döffinger wrote:
> > > > Yes, I'd like to use swab for all these modifications but the swab man
> > > > page did not say whether it works fine when src==dst.
> > > >
> > > > So, if you insist, I can give a bswap_16 version according to your
> > > > sample code. Here it is.
> > >
> > > Please just try it with swab, if it works we should use it IMO. If there
> > > are some weird systems where it does not work for src==dst we can write
> > > a replacement function for those.
> > >
> > > Otherwise the patch looks good to me.
> >
> > On second thought, could you test attached patch?
>
> And (assuming this works) which version do others prefer, this or the
> one using swab?
> Also, can someone test on different operating systems on bigendian?
> Preferably at least linux, *BSD and OSX (though I don't know if AC3
> works with OSX?)
>

It works with OS X on a G5 machine, but need an ao_macosx patch to
support passthrough, which I posted last month (according to vlc's
code)

And the whole idea comes from vlc's source, I re-checked vlc's code,
it decide whether to swap bytes by output stream's format flag as you
said in first reply instead of judging by machine byte-order. In vlc's
code, only audio output for mac os x can result a bigendian output
stream, other audio output for other platform all flag their output
stream as little-endian.
Indeed on mac os x, we can get the byte-order of spdif output stream,
but do we have any way to get it in hwac3? So, could we figure out a
way to get the output stream format flags of ao modules in hwac3?

-- 
Ulion