[MPlayer-dev-eng] [PATCH] bigendian fix for hwac3

Ulion ulion2002 at gmail.com
Thu Sep 13 13:58:53 CEST 2007


2007/9/13, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Sep 13, 2007 at 01:14:40PM +0200, Reimar Döffinger wrote:
> > > Yes, I'd like to use swab for all these modifications but the swab man
> > > page did not say whether it works fine when src==dst.
> > >
> > > So, if you insist, I can give a bswap_16 version according to your
> > > sample code. Here it is.
> >
> > Please just try it with swab, if it works we should use it IMO. If there
> > are some weird systems where it does not work for src==dst we can write
> > a replacement function for those.
> >
> > Otherwise the patch looks good to me.
>
> On second thought, could you test attached patch?
>
> Greetings,
> Reimar Döffinger

This patch will mix native byte-order with macro WORDS_BIGENDIAN, the
later one could be set by configure with enable/disable big-endian
flag which possibly be different with native byte-order, although they
could always be same.
I haven't tested this patch, it should work on powerpc native compile,
but I'm not sure if it work on a cross-compile. I don't think this
patch will make things more clear than earlier patch.
If you insist, I could test it with powerpc native compile, but a
cross-compile could be hard ( by now I haven't done a cross-compile
for mplayer with different byte-order yet.)


-- 
Ulion



More information about the MPlayer-dev-eng mailing list