[MPlayer-dev-eng] [PATCH] tv:// for win32

[Vladimir Voroshilov]

2007/9/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Sep 08, 2007 at 11:07:37PM +0700, Vladimir Voroshilov wrote:
> > Here is complete set of patches of
> > tv:// for win32 implementation (with teletext support)
> >
> > 1. dshow_cfg_v96.diff
> > cnonfigure, Makefile, options, translatable strings
>
> This one first...
>
> > +#include <ole2.h>
> > +int main(void) {
> > +    void* p;
> > +    CoCreateInstance((GUID*)&GUID_NULL, NULL, CLSCTX_INPROC_SERVER, &GUID_NULL, (void**)&p);
>
> At least that (void**) cast is entirely pointless.

Fixed.

> > +  cc_check -lole32 -luuid && _tv_dshow=yes
>
> Shouldn't you add those two libraries to the linker flags as well?

Hm. Fixed. I don't know why it compiles/works without this.

> > -#ifdef HAVE_TV_V4L2
> > +#ifdef HAVE_TV_V4L2 || defined(HAVE_TV_DSHOW)
>
> nope.

What does you mean?


> Weird idea putting this in the same patch as configure stuff (even if
> it's only split for reviewing) ;-)

Splitted.

> > +#define MSGTR_TVI_DS_E_UnableConnectInputVideoDecoder  "Unable to connect given input to video decoder. Error:0x%x\n"
>
> I'm not a big fan of single-letter name parts, even more so since this
> only duplicates information that you already have in the code due to
> MSGL_*.

Done.

Also fixed indentation and copy/paste errors in configure.
Updated patch attached.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dshow_cfg_v98.diff
Type: application/octet-stream
Size: 5765 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070909/742b35a2/attachment.obj>