[MPlayer-dev-eng] [PATCH] tv:// for win32

[Reimar Döffinger]

Hello,
On Sat, Sep 08, 2007 at 11:07:37PM +0700, Vladimir Voroshilov wrote:
> Here is complete set of patches of
> tv:// for win32 implementation (with teletext support)
> 
> 1. dshow_cfg_v96.diff
> cnonfigure, Makefile, options, translatable strings

This one first...

> +#include <ole2.h>
> +int main(void) { 
> +    void* p;
> +    CoCreateInstance((GUID*)&GUID_NULL, NULL, CLSCTX_INPROC_SERVER, &GUID_NULL, (void**)&p);

At least that (void**) cast is entirely pointless.

> +  cc_check -lole32 -luuid && _tv_dshow=yes

Shouldn't you add those two libraries to the linker flags as well?

> -#ifdef HAVE_TV_V4L2
> +#ifdef HAVE_TV_V4L2 || defined(HAVE_TV_DSHOW)

nope.

> Index: help/help_mp-en.h
> ===================================================================
> --- help/help_mp-en.h	(revision 24369)
> +++ help/help_mp-en.h	(working copy)

Weird idea putting this in the same patch as configure stuff (even if
it's only split for reviewing) ;-)

> +#define MSGTR_TVI_DS_E_UnableConnectInputVideoDecoder  "Unable to connect given input to video decoder. Error:0x%x\n"

I'm not a big fan of single-letter name parts, even more so since this
only duplicates information that you already have in the code due to
MSGL_*.

Greetings,
Reimar Döffinger