[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

Alexander Strange astrange at ithinksw.com
Sat Oct 20 01:42:27 CEST 2007


On Oct 19, 2007, at 8:44 AM, Rich Felker wrote:
>>>
>>
>> -vf 2xsai only supports one colorspace anyway, so they should be made
>> const values.
>> I remember this had a significant speedup when I did it ages ago to
>> the filters in SNES9X OS X.
>
> There's code later in the filter that changes these variables... Is it
> just cruft?
>
> Rich

If I understand query_format() right it only accepts BGR32, so  
they'll always be changed to the same thing.
Of course, someone might make it  work on 16-bit again, so all the  
init code might as well be kept around anyway.


More information about the MPlayer-dev-eng mailing list