[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

[Rich Felker]

On Fri, Oct 19, 2007 at 08:20:27AM -0400, Alexander Strange wrote:
> 
> On Oct 19, 2007, at 4:48 AM, Reimar Döffinger wrote:
> 
> >> Index: libmpcodecs/vf_2xsai.c
> >> ===================================================================
> >> --- libmpcodecs/vf_2xsai.c	(revision 24811)
> >> +++ libmpcodecs/vf_2xsai.c	(working copy)
> >> @@ -16,6 +16,8 @@
> >>  #define uint16 unsigned short
> >>  #define uint8 unsigned char
> >>
> >> +/* FIXME: these all belong in the context, not as globals! */
> >> +
> >>  static uint32 colorMask = 0xF7DEF7DE;
> >>  static uint32 lowPixelMask = 0x08210821;
> >>  static uint32 qcolorMask = 0xE79CE79C;
> >
> > Just put that in an extra commit ;-)
> > As long as it compiles, I think it can't hurt to apply right away.
> >
> > Greetings,
> > Reimar Döffinger
> 
> -vf 2xsai only supports one colorspace anyway, so they should be made  
> const values.
> I remember this had a significant speedup when I did it ages ago to  
> the filters in SNES9X OS X.

There's code later in the filter that changes these variables... Is it
just cruft?

Rich