[MPlayer-dev-eng] [PATCH] Fix parse comment bug for input.conf

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Oct 16 15:45:29 CEST 2007


Hello,
On Tue, Oct 16, 2007 at 09:43:35AM -0400, Rich Felker wrote:
> On Tue, Oct 16, 2007 at 03:02:04PM +0800, Ulion wrote:
> > For a reported bug:
> > http://lists.mplayerhq.hu/pipermail/mplayer-users/2007-October/069603.html
> > I tested, it is a bug when parsing input comand followed by comment in
> > the same line.
> > I make a patch for this, so when parse cmd, comment will be ignored.
> 
> Are you sure this does not break bindings/commands with # in them?

I think not, there is a strchr for a space directly before that IIRC, so
only the " #" sequence matches.
The code looks a bit weird though, it looks like using only tab to
separate the arguments won't work (I didn't check the code thoroughly
though).



More information about the MPlayer-dev-eng mailing list