[MPlayer-dev-eng] ctype.h functions on win32

[Rich Felker]

On Thu, Oct 11, 2007 at 07:03:23AM +0200, Gianluigi Tiesi wrote:
> Win32 crt's ctype functions like isalpha isspace etc
> are declared as int, but they return wrong results
> (using msvc 2005, you get an assert or crash)
> if the value is < 0

It's unclear from the spec what they're supposed to do. On the one
hand it says the application shall ensure that the value passed is a
valid value for unsigned char. But on the other hand, it says the
functions shall return a nonzero value if the argument is a character
of the corresponding type, and 0 otherwise (which could be interpreted
as meaning that 0 should be returned for invalid values as well).

In any case, why are we using these functions? They're bogus since
they only work for 8bit characters and not multibyte characters, and
MPlayer does not even use the locale anyway due to various issues, so
we might as well just code the ascii tests directly if ascii is all we
need...

> since unix has no problems even if the argument is unsigned
> it would be usefull to convert them or cast

The char pointers should be fixed to be unsigned char pointers, rather
than just casting..

> By looking at the code, there are some functions
> where it's enough to change char to unsigned char in arguments
> 
> other functions are more difficult since they use int
> since some api are still returning int like fgetc (deprecated iirc)

Huh?? Why would fgetc be deprecated? Returning int is correct for
fgetc. It returns a byte (unsigned char) or EOF (-1) if end of file is
reached or another error occurs. What type would you suggest it should
return to meet these needs?

> in these places the value can be casted to uint32_t

Absolutely not.

Rich