[MPlayer-dev-eng] ctype.h functions on win32

Gianluigi Tiesi mplayer at netfarm.it
Thu Oct 11 07:03:23 CEST 2007


Win32 crt's ctype functions like isalpha isspace etc
are declared as int, but they return wrong results
(using msvc 2005, you get an assert or crash)
if the value is < 0

since unix has no problems even if the argument is unsigned
it would be usefull to convert them or cast

By looking at the code, there are some functions
where it's enough to change char to unsigned char in arguments

other functions are more difficult since they use int
since some api are still returning int like fgetc (deprecated iirc)

in these places the value can be casted to uint32_t

there are a lot of changes to make, before making a patch
I would ask your suggestions

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/



More information about the MPlayer-dev-eng mailing list