[MPlayer-dev-eng] [PATCH] loader/win32.c cleanup of CreateFile should fix vp6vfw 2nd pass encoding on linux

[Gianluigi Tiesi]

On Tue, Oct 09, 2007 at 11:32:18AM +0200, Reimar D?ffinger wrote:
> Hello,
> On Tue, Oct 09, 2007 at 02:23:34AM +0200, Gianluigi Tiesi wrote:
> > I've made an updated patch, I've added a check
> > that CreateFileA would fail if the file exists and it's
> > not a regular file, i.e. a symlink, since
> > this can be a security issue
> 
> Actually those aren't any security concerns, the binary codec can simply
> do an open syscall (+ some code so it won't do that or at least not
> crash on Windows) and all this checking does not help a thing.
Checks are not called so often, but I think it's anyway a good idea
to avoid strange behaviours with binary only codecs

> The point of doing extra stuff here is so the codecs don't break the
> users system accidentally and also don't spread their crap all over the
> place like the do on windows.
the current expCreateFileA has a lot of non needed specific workarounds
> That said, what I don't like about this patch is that it leaves totally
> unclear why twopass did not work before.
because expCreateFileA doesn't correctly opens files in write mode
> If, as I assume, the problem is the codec writing a log file on the
> first pass, it would also be a nice feature if it could be redirected to
> the file specified by -passlogfile.
not applicable too much specific, or at least without
doing what it's in current expCreateFileA
but I sincerely don't like it

I've played with this stuff since I've received a lot
of requests to use vp6vfw, it's a cheap way to
produce flv files, win32 already has a working
two pass encoding, it uses native windows calls.

Perhaps I could cleanup the win32 loader, if interested.

Bye

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/