[MPlayer-dev-eng] [PATCH] loader/win32.c cleanup of CreateFile should fix vp6vfw 2nd pass encoding on linux

[Reimar Döffinger]

Hello,
On Tue, Oct 09, 2007 at 02:23:34AM +0200, Gianluigi Tiesi wrote:
> I've made an updated patch, I've added a check
> that CreateFileA would fail if the file exists and it's
> not a regular file, i.e. a symlink, since
> this can be a security issue

Actually those aren't any security concerns, the binary codec can simply
do an open syscall (+ some code so it won't do that or at least not
crash on Windows) and all this checking does not help a thing.
The point of doing extra stuff here is so the codecs don't break the
users system accidentally and also don't spread their crap all over the
place like the do on windows.
That said, what I don't like about this patch is that it leaves totally
unclear why twopass did not work before.
If, as I assume, the problem is the codec writing a log file on the
first pass, it would also be a nice feature if it could be redirected to
the file specified by -passlogfile.

Greetings,
Reimar Döffinger