[MPlayer-dev-eng] [PATCH] vobsub fix for empty useless streams

[Ulion]

2007/11/26, Ulion <ulion2002 at gmail.com>:
> 2007/10/31, Ulion <ulion2002 at gmail.com>:
> > 2007/10/30, Ulion <ulion2002 at gmail.com>:
> > > 2007/10/23, Ulion <ulion2002 at gmail.com>:
> > > > Reimar,
> > > >
> > > > Do you have any further suggestion/objection on this patch, or anybody
> > > > else? If none, I will apply this patch after a week.
> > > >
> > >
> > > I will apply this patch tomorrow if no one object.
> > >
> >
> > Consider this patch will change the vobsub stream number and
> > global_sub_count, which will affect some master programs running
> > mplayer in slave mode when calling 'sub_select' command to select a
> > subtitle by gui. I decide to delay applying this patch.
> > Before that, I will try to make a patch let sub_select support select
> > subtitle by id and type (SUB_FILE, VOBSUB, SUBTITLE embedded in video
> > file). With that patch, master programs will be more free and smooth
> > to select subtitles.
>
> OK, now the select sub by source patch already merged into svn, so I
> can safely change the vobsub code to skip empty subtitle streams.
>
> Here's the updated version for it. you can try it out by using console
> from osd menu and type sub_vob whatever to test it.
>
> Since the original patch already get discussed and passed, just
> because me it delayed to apply, so here I will make another 1 week
> delay for any suggestion and objection to apply it.

Fix to check empty vobsub stream by packets_size == 0 instead of empty
id. Now it should be skipped only when it's a really 'empty' vobsub
stream.
If no objects, I will apply this in 3 days.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vobsub_empty_sub_fix2.diff
Type: text/x-diff
Size: 6219 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071130/a58f9ba7/attachment.diff>