[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Ulion ulion2002 at gmail.com
Mon Nov 26 16:31:29 CET 2007


2007/11/25, Ulion <ulion2002 at gmail.com>:
> 2007/11/25, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Sat, Nov 24, 2007 at 12:27:13PM -0500, Rich Felker wrote:
> > > However I maintain that calling commands via the shell is
> > > fundamentally risky and bogus. Use fork(2) and exec*(2) functions.
> >
> > Can you maybe check the patch
> > "fake unrarlib using RAR executable" from April 17th, 2005?
> > I do not even know if it applies, but if people really so much want this
> > feature that patch seems much more elaborate than this and probably
> > could be cleaned up to be okay.
>
> That one looks did better than my this one, since that one has chance
> to be ok, I will switch work to that one.

OK, here's the updated patch base on the old patch, also tested work
on MinGW win32.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unrar_exec3.diff
Type: text/x-diff
Size: 16701 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071126/557d0a12/attachment.diff>


More information about the MPlayer-dev-eng mailing list