[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Ulion ulion2002 at gmail.com
Sun Nov 25 04:08:55 CET 2007


2007/11/25, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Nov 24, 2007 at 12:27:13PM -0500, Rich Felker wrote:
> > However I maintain that calling commands via the shell is
> > fundamentally risky and bogus. Use fork(2) and exec*(2) functions.
>
> Can you maybe check the patch
> "fake unrarlib using RAR executable" from April 17th, 2005?
> I do not even know if it applies, but if people really so much want this
> feature that patch seems much more elaborate than this and probably
> could be cleaned up to be okay.

That one looks did better than my this one, since that one has chance
to be ok, I will switch work to that one.

> Though honestly adding this add a more low-level place instead of
> emulating unrarlib would be better, and I _though_ there was such a
> patch, but I can't find it.

more low-level place, I'm not sure what you mean, but indeed emulating
unrarlib looks not so good. Can you make it clear?



-- 
Ulion



More information about the MPlayer-dev-eng mailing list