[MPlayer-dev-eng] [PATCH] vo_macosx.m - test proxy messages

[Chris Welton]

--- Ulion <ulion2002 at gmail.com> wrote:

> 2007/11/25, Chris Welton
> <electrostatic_1 at yahoo.com>:
> > Just because there is a registered connection
> named
> > "mplayerosx" with a proxy object does not mean we
> > should assume it will respond to our messages.
> 
> shared-buffer mode of mplayer vo_macosx only used by
> MPlayer OS X, why
> you think this? If for remove all warning messages,
> maybe we should
> set a proxy protocol for it instead of the
> obj_msgSend call, it looks
> a low level work of Cocoa which already be done
> under the framework I
> think.
> 
> >
> > This patch asks it before pushing data.
> 
> As I said, I think the Cocoa already check that, if
> obj not accept
> some call, it will print error log and keep going.
> 
> >
> > Also removes redundant id to type
> NSAutoReleasePool
> 
> Is it necessary?
> 
> -- 
> Ulion
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
>
http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 

As for the autorelease pool, yes it is somewhat
necessary, as you are leaving the other one pointing
to an object which no longer exists. You could set
that object to nil and then make a new one, but there
is no real need to. One works fine.

As for whether proxy automatically checks, I don't
know, but I do know other objects don't.. I'll test
it.

Chris


      ____________________________________________________________________________________
Be a better pen pal. 
Text or chat with friends inside Yahoo! Mail. See how.  http://overview.mail.yahoo.com/