[MPlayer-dev-eng] [PATCH] vo_macosx.m - test proxy messages

Ulion ulion2002 at gmail.com
Sun Nov 25 15:04:13 CET 2007


2007/11/25, Chris Welton <electrostatic_1 at yahoo.com>:
> Just because there is a registered connection named
> "mplayerosx" with a proxy object does not mean we
> should assume it will respond to our messages.

shared-buffer mode of mplayer vo_macosx only used by MPlayer OS X, why
you think this? If for remove all warning messages, maybe we should
set a proxy protocol for it instead of the obj_msgSend call, it looks
a low level work of Cocoa which already be done under the framework I
think.

>
> This patch asks it before pushing data.

As I said, I think the Cocoa already check that, if obj not accept
some call, it will print error log and keep going.

>
> Also removes redundant id to type NSAutoReleasePool

Is it necessary?

-- 
Ulion



More information about the MPlayer-dev-eng mailing list