[MPlayer-dev-eng] [PATCH] use inttypes.h if stdint.h is not available.
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Nov 22 18:55:06 CET 2007
Hello,
On Thu, Nov 22, 2007 at 05:58:57PM +0100, Diego Biurrun wrote:
> On Thu, Nov 22, 2007 at 03:09:22PM +0100, Ralf Menzel wrote:
[...]
> > --- libavutil/adler32.h (revision 11075)
> > +++ libavutil/adler32.h (working copy)
> > @@ -21,7 +21,11 @@
> > #ifndef FFMPEG_ADLER32_H
> > #define FFMPEG_ADLER32_H
> >
> > +#ifdef HAVE_STDINT_H
> > #include <stdint.h>
> > +#else
> > +#include <inttypes.h>
> > +#endif
>
> This patch belongs on ffmpeg-devel, not mplayer-dev-eng.
>
> I doubt this ugly #ifdef will be accepted. However, if it works, you
> could try exchanging all or most occurrences of stdint.h with
> inttypes.h. If that is more portable, it might be accepted.
I think that is unlikely to be accepted into FFmpeg, I expect esp.
Mans to be against it.
And actually I think I agree, because the change to "fix" the system is
much, much smaller: create a stdint.h with "#include inttypes.h".
That still will not be C99-compatible but will work at least as well as
the proposed changes (and will make some people notice how both outdated
and/or not standards-compliant their systems are, which is not a bad
thing either).
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list