[MPlayer-dev-eng] [PATCH] use inttypes.h if stdint.h is not available.
Rich Felker
dalias at aerifal.cx
Fri Nov 23 01:29:09 CET 2007
On Thu, Nov 22, 2007 at 05:58:57PM +0100, Diego Biurrun wrote:
> > --- libavutil/adler32.h (revision 11075)
> > +++ libavutil/adler32.h (working copy)
> > @@ -21,7 +21,11 @@
> > #ifndef FFMPEG_ADLER32_H
> > #define FFMPEG_ADLER32_H
> >
> > +#ifdef HAVE_STDINT_H
> > #include <stdint.h>
> > +#else
> > +#include <inttypes.h>
> > +#endif
>
> This patch belongs on ffmpeg-devel, not mplayer-dev-eng.
>
> I doubt this ugly #ifdef will be accepted. However, if it works, you
> could try exchanging all or most occurrences of stdint.h with
> inttypes.h. If that is more portable, it might be accepted.
This #ifdef is idiotic. Simply always use the case that works
everywhere. People who write ifdefs like this need to be taken out
back..
Rich
More information about the MPlayer-dev-eng
mailing list