[MPlayer-dev-eng] [PATCH] fix printf format string warnings

[Reimar Döffinger]

Hello,
On Thu, Nov 22, 2007 at 04:13:58PM +0100, Diego Biurrun wrote:
> On Thu, Nov 22, 2007 at 10:12:40AM -0500, Rich Felker wrote:
> > On Thu, Nov 22, 2007 at 01:34:38AM +0100, Diego Biurrun wrote:
[...]
> > > They are type long, see loader/wine/vfw.h.
> > 
> > Nonetheless I'm pretty sure that's a mistake and the correct type
> > would be int32_t..

Basically yes, but that's the way MS did it which in turn is probably
why they now defined long as always 32 bit...

> Isn't that orthogonal to my patch?  And Windows DLLs only work on 32 bit
> systems anyway, so ve_vfw.c couldn't care less.  Am I mistaken?

Othogonal? Well, if it was "fixed" that patch would have to be reverted
again (well, maybe using PRId32 etc. would be nicer, but not really
necessary).
Changing it in the header would probably very, very slightly simplify
adding support for 64 bit DLLs (not that I'm sure we'll ever add that).

Greetings,
Reimar Döffinger