[MPlayer-dev-eng] [PATCH] fix printf format string warnings

[Diego Biurrun]

On Thu, Nov 22, 2007 at 10:12:40AM -0500, Rich Felker wrote:
> On Thu, Nov 22, 2007 at 01:34:38AM +0100, Diego Biurrun wrote:
> > On Wed, Nov 21, 2007 at 01:22:03PM -0500, Rich Felker wrote:
> > > On Wed, Nov 21, 2007 at 11:49:10AM +0100, Diego Biurrun wrote:
> > > > This patch fixes a couple of "format '%d' expects type 'int', but
> > > > argument 2 has type 'long int'" warnings.  OK to apply?
> > > 
> > > What type are those struct fields? If they're something like uint32_t
> > > then either use constants from inttypes.h or cast to long before
> > > printing... Just assuming they're the same as long would be very wrong
> > > and break 64bit archs!
> > 
> > They are type long, see loader/wine/vfw.h.
> 
> Nonetheless I'm pretty sure that's a mistake and the correct type
> would be int32_t..

Isn't that orthogonal to my patch?  And Windows DLLs only work on 32 bit
systems anyway, so ve_vfw.c couldn't care less.  Am I mistaken?

Diego