[MPlayer-dev-eng] [Patch 2/2] dvd_set_speed fixes/addons

[Reimar Döffinger]

Hello,
On Fri, Nov 16, 2007 at 09:38:53PM +0100, Sebastian Kemper wrote:
> This patch adds some lines to reflect possible noise from the sg driver.
> The ioctl() will only error (return -1) during the first sg stage (that
> is up to and including the point where the driver issues the command to
> the drive). The next two stages (basically sense and data transfer)
> aren't checked by mplayer currently.

IMO that is no info that is really useful to the normal user, and sense
errors usually appear in the kernel log (or is that only some?)

[...]
> -  unsigned char sense[16];
> +  unsigned char sense[32];

Though if the sense data buffer must be 32 bytes this definitely should
be fixed...

Greetings,
Reimar Döffinger