[MPlayer-dev-eng] [Patch 2/2] dvd_set_speed fixes/addons

[Reimar Döffinger]

Hello,
On Sat, Nov 17, 2007 at 07:58:40PM +0100, Reimar Döffinger wrote:
> On Fri, Nov 16, 2007 at 09:38:53PM +0100, Sebastian Kemper wrote:
> > This patch adds some lines to reflect possible noise from the sg driver.
> > The ioctl() will only error (return -1) during the first sg stage (that
> > is up to and including the point where the driver issues the command to
> > the drive). The next two stages (basically sense and data transfer)
> > aren't checked by mplayer currently.
> 
> IMO that is no info that is really useful to the normal user, and sense
> errors usually appear in the kernel log (or is that only some?)
> 
> [...]
> > -  unsigned char sense[16];
> > +  unsigned char sense[32];
> 
> Though if the sense data buffer must be 32 bytes this definitely should
> be fixed...

Ah, no there is the mx_sb_len and that is set correctly.
But I decided that it (for now) makes more sense to get rid of that
sense buffer completely and thus simplify the code.

Greetings,
Reimar Döffinger