[MPlayer-dev-eng] uneeded if-def in mf demuxer (at least imho)

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Nov 17 18:29:24 CET 2007


Hello,
On Fri, Nov 16, 2007 at 02:16:48AM +0100, Gianluigi Tiesi wrote:
> This seems pointless to me:
> 
> #ifdef WIN32
>   if ( !( f=fopen( mf->names[mf->curr_frame],"rb" ) ) ) return 0;
> #else
>   if ( !( f=fopen( mf->names[mf->curr_frame],"r" ) ) ) return 0;
> #endif
> 
> rb is enough unix system will just ignore the flag
> or there is around an arch that will complain?

Actually, even if it works, only "rb" is correct, so changed.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list