[MPlayer-dev-eng] uneeded if-def in mf demuxer (at least imho)
Rich Felker
dalias at aerifal.cx
Sun Nov 18 19:33:26 CET 2007
On Sat, Nov 17, 2007 at 06:29:24PM +0100, Reimar Döffinger wrote:
> Hello,
> On Fri, Nov 16, 2007 at 02:16:48AM +0100, Gianluigi Tiesi wrote:
> > This seems pointless to me:
> >
> > #ifdef WIN32
> > if ( !( f=fopen( mf->names[mf->curr_frame],"rb" ) ) ) return 0;
> > #else
> > if ( !( f=fopen( mf->names[mf->curr_frame],"r" ) ) ) return 0;
> > #endif
> >
> > rb is enough unix system will just ignore the flag
> > or there is around an arch that will complain?
>
> Actually, even if it works, only "rb" is correct, so changed.
As a side note, I've found several broken programs that use a
nonexistant "rt" flag to intentionally open files in "text mode". If I
ever find any of that in mplayer there'll be a new world record for
forced cola consumption... :)
Rich
More information about the MPlayer-dev-eng
mailing list