[MPlayer-dev-eng] Updated nailfps filter patches

[Diego Biurrun]

On Mon, Nov 12, 2007 at 02:28:03AM -0500, xiphmont at xiph.org wrote:
> Updated version of the patch including requested changes.  manpage
> tidied, exit()s removed, messages now use mp_msg.
> 
> The are two minor additional changes, both to ao_pcm.  One adds a
> 'pipe' option to play more nicely with outputting to a pipe, the
> second fixes a bug that would pop up on bigendian (the variable that
> tracks the file length was clobbered to reverse endianness in place to
> save out in the wave header; that became an issue when used with
> multiple input files).
> 
> All in one patch this time as editing it into multiple patches caused
> heartache last time.

Split patches are preferred...

> --- libmpcodecs/vf_nailfps.c	(revision 0)
> +++ libmpcodecs/vf_nailfps.c	(revision 0)
> @@ -0,0 +1,205 @@
> +/*
> + *
> + *  vf_nailfps, part of MPlayer
> + *    
> + *      Copyright (C) 2007 Monty <monty at xiph.org>
> + *
> + */
> +
> +/* nailfps creates a fixed-frame-rate output, much like -ofps for mencoder. */

Stylistic nit: I prefer to have this description as the first line of
the file header.

> --- DOCS/man/en/mplayer.1	(revision 25005)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -5225,6 +5230,13 @@
>  .
> +discontinuities, seeks, and file transitions (when used with \-fixed-vo).

You need to escape all dashes, not just the first one.  All unescaped
dashes get interpreted as hyphens.

> @@ -6054,6 +6066,44 @@
>  .
> +\-fps is required. The "correct" frame rate to use with \-fps may be
> +different from the stream's claimed frame rate.  
> +An "incorrect" rate adds or subtracts single frames from the stream 
> +at regular intervals. A "correct" rate only adds/removes frames in short 
> +bursts, usually at edit points, scene changes, dropouts or other 
> +discontinuities.

New sentences on new lines please.

> +Also note that various other options (eg, \-mc or \-correct-pts) that

e.g.\&

> +Valid range is 0. through 2., default is .1.  

This is unclear.  Is the range 0.0 - 2.0 with a default of 0.1?  Then
say so.

> --- libaf/af_nailsync.c	(revision 0)
> +++ libaf/af_nailsync.c	(revision 0)
> @@ -0,0 +1,137 @@
> +/*
> + *
> + *  af_nailsync, part of MPlayer
> + *    
> + */
> +
> +
> +/* Nailsync watches audio pts and alters the metronome in vf_nailfps
> +   to fix audio and video sync together */

ditto

Diego