[MPlayer-dev-eng] Updated nailfps filter patches

[xiphmont at xiph.org]

On Nov 12, 2007 3:31 AM, Diego Biurrun <diego at biurrun.de> wrote:

> Stylistic nit: I prefer to have this description as the first line of
> the file header.

I went looking for examples, and didn't see any in any other files.
My filters are the first to have any sort of license at the top, and
the convention I'd seen everywhere else in other projects including my
own have the license first.

...just saying.  Alot of the nits don't seem to have consistent
detectable precedent elsewhere in the code.  I *have* been going
looking...  General complaint, not levied at this point specifically.

>
> > --- DOCS/man/en/mplayer.1     (revision 25005)
> > +++ DOCS/man/en/mplayer.1     (working copy)
> > @@ -5225,6 +5230,13 @@
> >  .
> > +discontinuities, seeks, and file transitions (when used with \-fixed-vo).
>
> You need to escape all dashes, not just the first one.  All unescaped
> dashes get interpreted as hyphens.

I misunderstood what exactly you meant my 'hyphen'.

>
> > @@ -6054,6 +6066,44 @@
> >  .
> > +\-fps is required. The "correct" frame rate to use with \-fps may be
> > +different from the stream's claimed frame rate.
> > +An "incorrect" rate adds or subtracts single frames from the stream
> > +at regular intervals. A "correct" rate only adds/removes frames in short
> > +bursts, usually at edit points, scene changes, dropouts or other
> > +discontinuities.
>
> New sentences on new lines please.

Missed that one.

> > +Also note that various other options (eg, \-mc or \-correct-pts) that
>
> e.g.\&

thanks.

>
> > +Valid range is 0. through 2., default is .1.
>
> This is unclear.  Is the range 0.0 - 2.0 with a default of 0.1?  Then
> say so.

...I did.  Oh you mean stick extra aeroes on things... OK.

Monty