[MPlayer-dev-eng] [PATCH] OSD menu #if 0 define remove and pause key bug fix

Ulion ulion2002 at gmail.com
Thu Nov 8 06:41:47 CET 2007


2007/11/6, Ulion <ulion2002 at gmail.com>:
> 2007/11/4, Ulion <ulion2002 at gmail.com>:
> > Hello,
> >
> > In libmenu/vf_menu.c, there's a #if 0 comment out 4 lines to prevent a
> > pause key bug (without osd menu showed but running mplayer with -menu
> > parameter), it from a link in 2003:
> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2003-March/017281.html
> > The comment out did prevent the pause key problem, but it kill the osd
> > menu pausing display (select pause from osd menu, after that, display
> > will no longer update but you can move the menu selection invisible).
> > Set #if 0 to #if 1, you will see what's the proper behavior after
> > select pause from osd menu.
> > The real reason cause the pause key problem descripted in the old
> > link, is that cmd filter handle all MP_CMD_PAUSE no matter whether
> > currently osd menu is displayed on the screen, it should only handle
> > MP_CMD_PAUSE when osd menu is displayed. Here's the real fix for that
> > problem.
>
> If no objects, I will apply this in two days.
>

Applied.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list