[MPlayer-dev-eng] [PATCH] OSD menu #if 0 define remove and pause key bug fix

[Alban Bedel]

On Sun, 4 Nov 2007 16:16:53 +0800
Ulion <ulion2002 at gmail.com> wrote:

> Hello,
> 
> In libmenu/vf_menu.c, there's a #if 0 comment out 4 lines to prevent a
> pause key bug (without osd menu showed but running mplayer with -menu
> parameter), it from a link in 2003:
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2003-March/017281.html
> The comment out did prevent the pause key problem, but it kill the osd
> menu pausing display (select pause from osd menu, after that, display
> will no longer update but you can move the menu selection invisible).
> Set #if 0 to #if 1, you will see what's the proper behavior after
> select pause from osd menu.
> The real reason cause the pause key problem descripted in the old
> link, is that cmd filter handle all MP_CMD_PAUSE no matter whether
> currently osd menu is displayed on the screen, it should only handle
> MP_CMD_PAUSE when osd menu is displayed. Here's the real fix for that
> problem.

Sorry I haven't much time for all this atm. Your patch is fine for the
current code, but this is not the real fix.

The pause filter was meant to work all the time to also eventualy allow
setting volume, etc when paused but not displaying the menu. The bug
was introduced in R8245, the added if is not at the right position so
it also skip code meant to run at every frame (like the pause stuff)
and things go havoc when the menu is not displayed. It should be enouth
to just move the if further down to just enclose the drawing code, and
get the original behaviour back.

	Albeu