[MPlayer-dev-eng] [PATCH] Fix for vo macosx play window not actived bug on leopard

[Diego Biurrun]

On Sun, Nov 04, 2007 at 01:11:57PM +0800, Ulion wrote:
> 2007/11/4, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Sun, Nov 04, 2007 at 02:29:59AM +0800, Ulion wrote:
> > [...]
> > > If you insist, I can also accept the patch remove os version check,
> > > since it will work anyway.
> >
> > I don't insist, I just wanted to make sure you know it _usually_ is bad to do
> > things like this.
> > If you suspect that this maybe even is a bug in some OSX code better add
> > a comment saying so as well IMO.
> 
> Thanks, I added comment for it, and limit the code only work when
> config without SDL (I did some test with SDL the play window has no
> problem, but if without it, will has problem on Leopard.)

I second what Reimar said: Such a workaround needs a comment at the very
least but should better be avoided at almost any cost.  It will become a
maintenance nightmare in the long run.

Diego