[MPlayer-dev-eng] [PATCH] Fix for vo macosx play window not actived bug on leopard

Ulion ulion2002 at gmail.com
Sun Nov 4 06:11:57 CET 2007


2007/11/4, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Nov 04, 2007 at 02:29:59AM +0800, Ulion wrote:
> [...]
> > If you insist, I can also accept the patch remove os version check,
> > since it will work anyway.
>
> I don't insist, I just wanted to make sure you know it _usually_ is bad to do
> things like this.
> If you suspect that this maybe even is a bug in some OSX code better add
> a comment saying so as well IMO.
>

Thanks, I added comment for it, and limit the code only work when
config without SDL (I did some test with SDL the play window has no
problem, but if without it, will has problem on Leopard.)
And also a fix for the patch to only work on no-sharedbuffer mode.
Ps: I notice in SDL 1.3 SVN, the bootstrap code we used currently by
include SDL.h seems not exists in the lib anymore, it be moved to act
as an application template. Maybe after SDL 1.3 released, we need a
patch for it.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_macosx_active_leopard_fix3.diff
Type: text/x-diff
Size: 1256 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071104/51d37141/attachment.diff>


More information about the MPlayer-dev-eng mailing list