[MPlayer-dev-eng] Re: [PATCH] add support for big-endian PCM output

[Grant Edwards]

On 2007-03-22, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> On Thursday, 22 March 2007 at 21:26, Grant Edwards wrote:
>> On 2007-03-22, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
>>> On Wednesday, 21 March 2007 at 19:42, Giacomo Comes wrote:
>>>> On Wed, Mar 21, 2007 at 05:11:29PM +0000, Grant Edwards wrote:

>>>>> I needed to be able to encode to 16-bit uncompressed big-endian PCM.
>>>>> [...]
>>>>> Although it works I have a feeling that this wasn't really the
>>>>> "right" way to do it.  If anybody would care to comment or
>>>>> suggest a better way to get big-endian PCM output please feel
>>>>> free to do so.
>>>>
>>>> I did create some time ago a patch that allow to use the option -format 
>>>> togheter with -ao pcm:nowaveheader.
>>>> [...]
>>>>
>>>> Could you use my (simpler) patch for your purpose?
>>>
>>> Cosmetics. ;)
>>
>> Sorry, I don't understand.  
>
> He's mixing cosmetic changes (adding a semicolon) with the
> rest of the patch (which is functional). IOW, I'm nitpicking.

So the (unasked) question you're answering is why his patch
wasn't accepted?

-- 
Grant Edwards                   grante             Yow!  I demand IMPUNITY!
                                  at               
                               visi.com