[MPlayer-dev-eng] Re: [PATCH] add support for big-endian PCM output

[Dominik 'Rathann' Mierzejewski]

On Thursday, 22 March 2007 at 21:26, Grant Edwards wrote:
> On 2007-03-22, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> > On Wednesday, 21 March 2007 at 19:42, Giacomo Comes wrote:
> >> On Wed, Mar 21, 2007 at 05:11:29PM +0000, Grant Edwards wrote:
> >> > [I posted this to the mencoder-user list a while back. Judging
> >> > by the lack of any sort of rsopnse that was the wrong forum.]
> >> > 
> >> > I needed to be able to encode to 16-bit uncompressed big-endian
> >> > PCM.  I couldn't get either "-format sb16be" or "-af format=s16be" 
> >> > to encode to big-endian format, so I gave up and added a "pcms"
> >> > audio encoder that swaps the byte-order of the data stream.  In
> >> > order to get lavf containers to label the stream correctly, I
> >> > had to invent a new "wav" audio tag for big-endian PCM.
> >> > 
> >> > Although it works I have a feeling that this wasn't really the
> >> > "right" way to do it.  If anybody would care to comment or
> >> > suggest a better way to get big-endian PCM output please feel
> >> > free to do so.
> >> > 
> >> > Anyway, the patch is available at 
> >> > 
> >> > http://www.visi.com/~grante/sansa/mplayer-1.0rc1-encode-bigendian-pcm.patch
> >> 
> >> I did create some time ago a patch that allow to use the option -format 
> >> togheter with -ao pcm:nowaveheader.
> >> 
> >> The thread start here:
> >> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-August/045084.html
> >> 
> >> There was some discussion about the patch, but then it was totally forgotten.
> >> 
> >> I'm sending it again with the hope that this time it will be considered
> >> (it still apply against current svn).
> >> 
> >> Could you use my (simpler) patch for your purpose?
> >
> > Cosmetics. ;)
> 
> Sorry, I don't understand.  
> 
> I know what the word "cosmetics" means, but I can't figure out
> what question you're answering or what statement you're making.

He's mixing cosmetic changes (adding a semicolon) with the rest
of the patch (which is functional). IOW, I'm nitpicking.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan