[MPlayer-dev-eng] Re: [PATCH] (De)activate pp with 'D'

[Michael Niedermayer]

Hi

On Sun, Mar 18, 2007 at 11:14:57PM +0000, Carl Eugen Hoyos wrote:
> Hi!
> 
> Dominik 'Rathann' Mierzejewski <dominik <at> rangers.eu.org> writes:
> 
> > What will happen if someone uses -vf kerndeint,pp=de for example? Do both
> > filters get activated? IMHO if we start assigning keys to enable/disable
> > filters, we'll run out of keys very quickly. I don't like this feature.
> 
> Thanks for explaining.
> 
> Am I right that you object to this patch (to vf_pp.c), but not to the one to
> vf_kerndeint.c?

i object to the vf_pp.c patch too, vf_pp is not only a deinterlacer disabling
it completely is incorrect

also iam more in favor of a generic enable/disable feature
somethng like "foobar-key" + number which identifies the filter to toggle
its enabled status

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070319/de0344a3/attachment.pgp>