[MPlayer-dev-eng] Re: [PATCH] (De)activate pp with 'D'

Vladimir Mosgalin mosgalin at VM10124.spb.edu
Mon Mar 19 00:49:06 CET 2007


Hi Carl Eugen Hoyos!

 On 2007.03.18 at 23:14:57 +0000, Carl Eugen Hoyos wrote next:

> > What will happen if someone uses -vf kerndeint,pp=de for example? Do both
> > filters get activated? IMHO if we start assigning keys to enable/disable
> > filters, we'll run out of keys very quickly. I don't like this feature.
> 
> Thanks for explaining.
> 
> Am I right that you object to this patch (to vf_pp.c), but not to the one to
> vf_kerndeint.c?

How about making user-defined filter activate on input event, would that
be too hard?

For example, is there a way of toggling yadif filter on/off? It is
the only descent deinterlacing filter that mplayer has, quality of the
rest of them is either poor (md, l5) or just unacceptable (the rest of
them). IMHO, if mplayer would get the ability to turn deinterlacing
on/off on keypress, yadif filter definitely should be used. Or, as an
alternative, the filter that user has choosen in config..

-- 

Vladimir



More information about the MPlayer-dev-eng mailing list