[MPlayer-dev-eng] PATCH [7/12] CoreAVC support (Take 3)

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Mar 4 16:48:42 CET 2007


Hello,
On Tue, Feb 27, 2007 at 12:43:49PM -0800, Alan Nisota wrote:
> +static LONG WINAPI explstrlenW(const WCHAR* str1)

The type is
int WINAPI lstrlenW(LPCWSTR)
at least on MinGW and MSDN, no const and no LONG there
(even though the const would be appropriate).
And IMO change str1 -> str.

> +{
> +    LONG len = 0;
> +    while(str1[len++]);

while(str1[len]) len++;

Might be more readable for some and you don't need the -1 below.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list