[MPlayer-dev-eng] [PATCH 1/4] String handling audit/cleanup
njkain at gmail.com
Fri Mar 2 22:04:23 CET 2007
On 3/2/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> text/plain attachments would have made replying much simpler.
Yeah, I'll try to do that. I'm used to sending via mutt inlining, but
I was unsure on what criteria the mailman list manager filters
non-subscribers, and my usual mode of sending email via mutt will come
from a less stable address.
> Most of the sprintf->snprintf changes are either pointless or just plain
> wrong (esp. in asxparser).
> Submitting the changes to use strlcpy/strlcat alone probably speeds up
> things a lot since they are simple to review and simplify the code, so
> have a real advantage, whereas snprintf tends to obfuscate.
That one is an exception where I mechanically converted a proper
strlcpy/strlcat form back onto the sprintf idiom, since I wanted to be
minimally disruptive. Fatigue got me there. It will be fixed, and I
think it should be the only bug of that class.
Splitting out strlcpy/strlcat from the other changes isn't really
going to be easy for me at this point. My patchsets are per-file
rather than per-type, since it's much more efficient for me to work
that way. Conversion would require a lot of copy/paste at this point,
which would likely introduce broken whitespace or more serious errors,
and it would take quite a lot of time at this point.
Audits aren't too much fun to do, and going per-file for a single
class of problem is the only way to really manage the work efficiently
More information about the MPlayer-dev-eng