[MPlayer-dev-eng] [PATCH 1/4] String handling audit/cleanup

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Mar 2 21:48:16 CET 2007


Hello,
On Fri, Mar 02, 2007 at 03:22:45PM -0500, Nicholas Kain wrote:
> String cleanups for the files in the root directory of the tree.
> 
> I meant for this to be threaded, but I've not been getting messages
> back from the list, although the previous message is showing up on
> gmane.  Sorry about that.

text/plain attachments would have made replying much simpler.
Most of the sprintf->snprintf changes are either pointless or just plain
wrong (esp. in asxparser).
Submitting the changes to use strlcpy/strlcat alone probably speeds up
things a lot since they are simple to review and simplify the code, so
have a real advantage, whereas snprintf tends to obfuscate.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list