[MPlayer-dev-eng] [PATCH] unify x11 window creation an handling

[Reimar Döffinger]

Hello,
On Wed, Jun 27, 2007 at 10:37:43AM +0200, Attila Kinali wrote:
> Moin Reimar,
> On Tue, 26 Jun 2007 20:16:29 +0200
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 
> > attached patch makes most x11-based vos use the same code to create and
> > otherwise handle windows in config().
> > I will apply rather soon, since the current mess makes it absolutely
> > impossible to fix bugs or even get a consistent behaviour.
> 
> I only scrolled quickly trough the patch and didn't see anything
> wrong. But you should add doxygen comments to vo_x11_create_vo_window
> and reindent the files where necessary.

I'll see about reindent. Though I hope to get rid of even more code, but
the similarities there are less (like the different colourmaps, do they
really need to be different?).

> So, just go ahead and commit it.

Done, while removing also two arguments that were the same global
variables always anyway.

Greetings,
Reimar Döffinger