[MPlayer-dev-eng] [PATCH] unify x11 window creation an handling

Attila Kinali attila at kinali.ch
Wed Jun 27 10:37:43 CEST 2007


Moin Reimar,

On Tue, 26 Jun 2007 20:16:29 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> attached patch makes most x11-based vos use the same code to create and
> otherwise handle windows in config().
> I will apply rather soon, since the current mess makes it absolutely
> impossible to fix bugs or even get a consistent behaviour.

I only scrolled quickly trough the patch and didn't see anything
wrong. But you should add doxygen comments to vo_x11_create_vo_window
and reindent the files where necessary.

So, just go ahead and commit it.

			Attila Kinali

-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred



More information about the MPlayer-dev-eng mailing list