[MPlayer-dev-eng] [PATCH] x11 vo drivers override user settings for window placement

Attila Kinali attila at kinali.ch
Mon Jun 25 10:06:03 CEST 2007


On Sun, 24 Jun 2007 13:57:18 -0700
"Mark Tiefenbruck" <mark at fluxbox.org> wrote:

> I see the problem here. You've confused mplayer with a window manager.

No we don't. MPlayer doesn't manage its window. It just tells the
WM in an unmistakable way what it preferes at _mapping_time_.

> Here are some quotes from that strange document you mentioned,

Strange document? It's the standard on how X11 clients should
communicate with each other. And if you are really a fluxbox
developer as your email adress suggests, then you should know
it by heart.

> Keep reading on your own.

I've read it quite a few times when the code in question
was written. What you have here is a missunderstanding on
what MPlayer should be doing and what not. Rule of thumb is
that an application should not force a specific window position
or size on the user/WM. But, unlike with other application,
people want that the video window is at the top and centered
on their screen on startup. MPlayer does that, but it is also
the only thing it does. Everything what happens _after_ the
move/resize is up to the user/WM and MPlayer will neither complain
about it nor force its believe on what is right on the user/WM.

The code you are questioning here has been written at an very
early stage of the MPlayer development and had got its share
of testing and review. And so far, i don't remember anyone
complain about the fact that the MPlayer window comes up
centered (actualy there were a lot of complaints when it
didn't happen). So, you being the first one who dislikes
this behavior in 5 or 6 years, i guess the code cannot be
that wrong.

So, again, to solve your problem use -geometry.
If that is not enough for you and you really want
that MPlayer does not set its position and size 
at mapping time, make a patch that disables
this behaviour by a command line switch, but leave
it enabled by default. Anything else is not acceptable.


		Attila Kinali
-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred



More information about the MPlayer-dev-eng mailing list