[MPlayer-dev-eng] [PATCH] correct teletext-option in configure

[Reimar Döffinger]

Hello,
On Wed, Jun 20, 2007 at 06:52:08PM +0300, Uoti Urpala wrote:
> On Wed, 2007-06-20 at 17:12 +0200, Reimar Döffinger wrote:
> > On Wed, Jun 20, 2007 at 05:04:23PM +0200, Sascha Klockow wrote:
> > > in the configure-script is a typing error. `configure --help` displays
> > > --disable-tv-teletex, but it checks a --disable-tv-teletext.
> > 
> > Wasn't the code that added this to be reverted anyway for proper
> > review?
> 
> AFAIK nobody spotted problems bad enough to require reverting it, but I
> suppose it hasn't received much review either way (which probably means

Hmm.. the number of lines of code alone seem almost qualifying. And a
gut feeling of several developers that it is not up to the standards of
code we usually impose nowadays...

> that if it was reverted it would never be applied again in any fixed
> form).

I will review and get into applyable state most patches if I'm bugged.
Of course if writing a reminder once a week or so and trying to
compromise with my suggestions is asked too much it won't happen, that
is true.

> > If the general impression that the patch was not exactly assembled with
> > care we will be reviewing and applying such small fixes for months
> > (assuming the feature will actually be used).
> 
> If you really think it'll take months to fix when it's committed then it
> would take much longer still to fix in patch form and could just as well
> be permanently dropped rather than reviewed.

Number of developers who cared before it was commited: at least the
commiter
Number of developers caring afterwards: 0.

And the thread discussing it was pondering a completely different
(and much better) approach which means that having this in the tree
might completely waste everyones time, so dropping it might actually be
the better option.

Greetings,
Reimar Döffinger