[MPlayer-dev-eng] [PATCH] correct teletext-option in configure

[Uoti Urpala]

On Wed, 2007-06-20 at 17:12 +0200, Reimar Döffinger wrote:
> Hello,
> On Wed, Jun 20, 2007 at 05:04:23PM +0200, Sascha Klockow wrote:
> > in the configure-script is a typing error. `configure --help` displays
> > --disable-tv-teletex, but it checks a --disable-tv-teletext.
> 
> Wasn't the code that added this to be reverted anyway for proper
> review?

AFAIK nobody spotted problems bad enough to require reverting it, but I
suppose it hasn't received much review either way (which probably means
that if it was reverted it would never be applied again in any fixed
form).

> If the general impression that the patch was not exactly assembled with
> care we will be reviewing and applying such small fixes for months
> (assuming the feature will actually be used).

If you really think it'll take months to fix when it's committed then it
would take much longer still to fix in patch form and could just as well
be permanently dropped rather than reviewed.