[MPlayer-dev-eng] [PATCH] TV teletext (try 2)

[Vladimir Voroshilov]

Hi, Uoti

2007/6/11, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> On Mon, 2007-06-11 at 11:32 +0700, Vladimir Voroshilov wrote:
> > First, is this command sequence enough good to revert r23530 ?
>
> I think it's premature to talk about reverting the patch. It doesn't
> seem to directly break anything else. While the code does seem to have
> some quality issues I don't think the ones brought up so far justify
> reverting it completely.
I don't want to revert it. If it possible i prefer to fix bad things.
Anyway i will not do it untill devs (Diego?) directly ask me to do so.

> > svn commit -m "revert r23530 (teletext support). It breaks policy,
> > other devs were not able to review patch before commit, code should be
> > cleaned up/fixed"
>
> Posting this patch first would have been good as it clearly would have
> benefited from review. However failing to do that is not in itself a
> reason to revert. Do you yourself believe that there are so many issues
> to "clean up/fix" that it's better to revert and start from scratch
> rather than try to fix the currently committed code?
I'm not sure in rendering part.
Best solution will be implementing something like independent from
teletext 'spu_draw_rgba(spu,rgba_image)'.
Perhaps osd stuff (text mode rendering) should also be checked once again.

Other looks enough good for me but Diego says that docs is buggy,
mixed tabs/spaces presents and code near build system should be fixed
in every line.

To aware misundestands:
I  have commited modified version of Otvos's patch, not just aplied
provided by him version.

Question to devs:

Should i revert this patch or not ?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719