[MPlayer-dev-eng] [PATCH] TV teletext (try 2)

[Uoti Urpala]

On Mon, 2007-06-11 at 11:32 +0700, Vladimir Voroshilov wrote:
> First, is this command sequence enough good to revert r23530 ?

I think it's premature to talk about reverting the patch. It doesn't
seem to directly break anything else. While the code does seem to have
some quality issues I don't think the ones brought up so far justify
reverting it completely.

> svn commit -m "revert r23530 (teletext support). It breaks policy,
> other devs were not able to review patch before commit, code should be
> cleaned up/fixed"

Posting this patch first would have been good as it clearly would have
benefited from review. However failing to do that is not in itself a
reason to revert. Do you yourself believe that there are so many issues
to "clean up/fix" that it's better to revert and start from scratch
rather than try to fix the currently committed code?