[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

Zuxy Meng zuxy.meng at gmail.com
Sun Jun 10 13:04:57 CEST 2007


Hi,

2007/6/10, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Jun 10, 2007 at 05:27:42PM +0800, Zuxy Meng wrote:
> [...]
> > > IMHO it's natural to use pan to implement balance. Although the term
> > > (pan and balance) themselves do not have quite identical meanings,
> > > they are often used interchangeably and I see no reason to implement a
> > > new "balance" audio filter. But one difference is that balance
> > > shouldn't alter the # of channels. Maybe we can differentiate the use
> > > of pan as a balancer with a static variable? See attached patch.
> >
> > What about this one, Reimar?
>
> You can not use global variables in filters. Also this is like storing
> the nch value in some other place that does not get overwritten as I
> suggested just uglier as it needs extra code.

I got tired about this issue.  All I want is an audio filter used for
balancing that can be 'af_add()'ed at runtime and doesn't alter the #
of channels before and after it. If one day you come up with an ideal
solution, pls kindly ping me.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list