[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jun 10 12:09:20 CEST 2007


Hello,
On Sun, Jun 10, 2007 at 05:27:42PM +0800, Zuxy Meng wrote:
[...]
> > IMHO it's natural to use pan to implement balance. Although the term
> > (pan and balance) themselves do not have quite identical meanings,
> > they are often used interchangeably and I see no reason to implement a
> > new "balance" audio filter. But one difference is that balance
> > shouldn't alter the # of channels. Maybe we can differentiate the use
> > of pan as a balancer with a static variable? See attached patch.
> 
> What about this one, Reimar?

You can not use global variables in filters. Also this is like storing
the nch value in some other place that does not get overwritten as I
suggested just uglier as it needs extra code.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list