[MPlayer-dev-eng] [PATCH] Disable optimizations when compiling with icc

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jun 10 11:00:49 CEST 2007


Hello,
On Sun, Jun 10, 2007 at 01:56:19AM +0200, Carl Eugen Hoyos wrote:
> icc doesn't support __attribute__((used)), so compilation with asm code
> is impossible atm.
> 
> Following patch disables mmx etc. in configure if not forced to make
> compilation with icc easier.

I guess it will have weird effects with runtime cpudetection. Also a
MPlayer binary without asm optimization is IMO rather useless. And
lastly I think last time even some of the non-MMX/SSE/3DNOW asm would
not compile.
IMO print a big warning that recommends using --target=generic-linux
that the user has to confirm. Since ICC is not really supported such a
message similar to the one for a certain older gcc version isn't a bad
idea (also since libmpeg2 probably still compiles but the result is broken).
I am also certain that all these "hacks" were not needed for version
8.x, maybe it did not support asm() at all?

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list