[MPlayer-dev-eng] [PATCH] Disable optimizations when compiling with icc

[Carl Eugen Hoyos]

Hi Reimar!

Reimar Doeffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

> On Sun, Jun 10, 2007 at 01:56:19AM +0200, Carl Eugen Hoyos wrote:
> > icc doesn't support __attribute__((used)), so compilation with asm code
> > is impossible atm.
> > 
> > Following patch disables mmx etc. in configure if not forced to make
> > compilation with icc easier.
> 
> I guess it will have weird effects with runtime cpudetection. Also a
> MPlayer binary without asm optimization is IMO rather useless. And
> lastly I think last time even some of the non-MMX/SSE/3DNOW asm would
> not compile.

Could you give an example for something that possibly wouldn't work? I only
tested xvmc, xvidix, xv, rtsp, wmv9dmo, ac3, aac, mp3, vc1, mpeg2, mpeg4 and
avc, because that's what I typically use.

> IMO print a big warning that recommends using --target=generic-linux

How should target=generic-linux help? Would that deactivate optimizations in
libswscale, liba52 and mp3lib?

> that the user has to confirm. Since ICC is not really supported such a
> message similar to the one for a certain older gcc version isn't a bad
> idea (also since libmpeg2 probably still compiles but the result is broken).

How could this be tested? For me, it produces output that looks correct.

> I am also certain that all these "hacks" were not needed for version
> 8.x, maybe it did not support asm() at all?

Sorry, I only tested 10.0

Thanks for looking at the patch, Carl Eugen