[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, the Finale

[Dominik 'Rathann' Mierzejewski]

On Thursday, 07 June 2007 at 12:32, Guillaume POIRIER wrote:
> Hi,
> 
> On 6/7/07, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> 
> > > Index: mp3lib/sr1.c
> > > ===================================================================
> > > --- mp3lib/sr1.c      ?????? 23483??
> > > +++ mp3lib/sr1.c      ????????????
> > > @@ -32,8 +32,9 @@
> > >
> > >  #include "libvo/fastmemcpy.h"
> > >
> > > -#ifdef ARCH_X86_32
> > > -#define CAN_COMPILE_X86_ASM
> > > +#ifdef ARCH_X86_64
> > > +#undef HAVE_3DNOW
> > > +#undef HAVE_3DNOWEX
> > >  #endif
> >
> > I still don't like the above. It's unintuitive, because my AMD64 has both
> > 3DNow and 3DNowExt.
> 
> What do you subject instead of this? 3dnow* code doesn't compile on AMD64.
> 
> All I can see that can be done is add a comment.

I'm fine with a comment.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan