[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, the Finale

Guillaume POIRIER poirierg at gmail.com
Thu Jun 7 12:32:46 CEST 2007


Hi,

On 6/7/07, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:

> > Index: mp3lib/sr1.c
> > ===================================================================
> > --- mp3lib/sr1.c      ?????? 23483??
> > +++ mp3lib/sr1.c      ????????????
> > @@ -32,8 +32,9 @@
> >
> >  #include "libvo/fastmemcpy.h"
> >
> > -#ifdef ARCH_X86_32
> > -#define CAN_COMPILE_X86_ASM
> > +#ifdef ARCH_X86_64
> > +#undef HAVE_3DNOW
> > +#undef HAVE_3DNOWEX
> >  #endif
>
> I still don't like the above. It's unintuitive, because my AMD64 has both
> 3DNow and 3DNowExt.

What do you subject instead of this? 3dnow* code doesn't compile on AMD64.

All I can see that can be done is add a comment.

Guillaume
-- 
Subversion has been the most pointless project ever started
  -- Linus Torvalds



More information about the MPlayer-dev-eng mailing list